Default TLS ServerName to the host in the DSN. #283
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A TLS configuration must either have a ServerName or specify InsecureSkipVerify. In most cases, the ServerName value will match the host part of the address in the DSN. This change updates the DSN parser to default the ServerName to the host value provided unless InsecureSkipVerify is specified.
|
LGTM |
julienschmidt
added a commit
that referenced
this pull request
Dec 10, 2014
Default TLS ServerName to the host in the DSN.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A TLS configuration must either have a ServerName or specify InsecureSkipVerify. In most cases, the ServerName value will match the host part of the address in the DSN. This change updates the DSN parser to default the ServerName to the host value provided unless InsecureSkipVerify is specified.